Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input sets are publicly declared as either
Set<T>
orReadonlySet<T>
. And in TypeScript,Set
extendsReadonlySet
. Because it is functionally the same type but with extra properties for mutability.When this library was initially written, each function exposed a generic
S
that extendedReadonlySet
. This guaranteed that the return type would be the same as the input set types. And, when declared types were added to this library inv1.1.0
, that typing paradigmS
remained. But for internal use only, as only explicit cases forSet -> Set
andReadonlySet -> ReadonlySet
are exposed in the distribution.Because there are declared types for each function, that generic is no longer internally necessary.
Set
extendsReadonlySet
. So each function can be internally typed withReadonlySet
. And theresultSets
no longer need to be cast toS
on return.